TNL-213: Student Notes - #6610
Closed
tymofij wants to merge 47 commits into
Closed
Conversation
Co-Authored-By: Tim Babych <tim.babych@gmail.com>
* revising notes view styling scope to use a <body> class * revising HTML basics: indentation levels, button UI classes, view-level styling and semantics * basic Sass/CSS clean up * deeper Sass/CSS clean up + abstraction * typography syncing * refining and defining notes visual color * changing reference heading copy * revising Student Notes visual styling * revising no search results styling/UI * revising search error styling/UI
* syncing student notes color schemes * overriding vendor UI/styling to match LMS UI * syncing up notes view tab spacing/alignment * syncing up icons used in notes + LMS * removing truncation from student-made note/comment on highlight * addressing note-highlight styling
Contributor
Author
|
actually, lets have discussion back in original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to make highlights and notes in courseware (only in html components at the moment) and to refer back to later.
Student Notes
sandbox: http://edxnotes.m.sandbox.edx.org/
Please make sure you're on MIT VPN to test the sandbox
This is the same code as https://github.com/edx/edx-platform/pull/6321 but with xblock.get_parent() replaced by less intrusive get_parent_xblock() function.
tested with
draftandsplitmodulestores.@olmar @polesye @jimabramson @andy-armstrong @cahrens please take a look at commit
edx@b4d2d10